pachamaltese commented on pull request #9999:
URL: https://github.com/apache/arrow/pull/9999#issuecomment-827009715


   a few questions
   
   should we skip tests on grouped data (not supported in Arrow) or pass it to 
R with warning?
   
https://github.com/pachamaltese/arrow/blob/arrow11755v2/r/tests/testthat/test-dplyr-mutate.R#L557
   
   I'm 0 sure about tests with 0 rows, how would you sketch that?
   
https://github.com/pachamaltese/arrow/blob/arrow11755v2/r/tests/testthat/test-dplyr-mutate.R#L522
   
   the same about not overwriting variables, does this look ok? 
   
https://github.com/pachamaltese/arrow/blob/arrow11755v2/r/tests/testthat/test-dplyr-mutate.R#L514


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to