Jefffrey commented on code in PR #9102:
URL: https://github.com/apache/arrow-rs/pull/9102#discussion_r2666622642


##########
arrow-row/src/lib.rs:
##########
@@ -435,6 +470,11 @@ mod variable;
 ///
 /// The order of a given column can be reversed by negating the encoded bytes 
of non-null values
 ///
+/// ## Union Ordering
+///
+/// Values of the same type are ordered according to the ordering of that type.
+/// Values of different types are ordered by their type id.

Review Comment:
   Would be good to mention reversing via negating the `type_id` here:
   
   
https://github.com/apache/arrow-rs/blob/2507946be697d511689a8f59b6a7db45ef40854b/arrow-row/src/lib.rs#L1742-L1747



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to