alamb commented on code in PR #9114:
URL: https://github.com/apache/arrow-rs/pull/9114#discussion_r2670377335
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -943,15 +943,15 @@ impl<'a, T: ByteViewType + ?Sized> IntoIterator for &'a
GenericByteViewArray<T>
}
impl<T: ByteViewType + ?Sized> From<ArrayData> for GenericByteViewArray<T> {
- fn from(value: ArrayData) -> Self {
- let views = value.buffers()[0].clone();
Review Comment:
`clone`ing the buffers is relatively cheap (they are `Arc`d internally) so
avoiding this just makes the code easier to follow, I don't think it will be
any significant savings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
