kou commented on code in PR #925:
URL: https://github.com/apache/arrow-java/pull/925#discussion_r2670890901
##########
gandiva/CMakeLists.txt:
##########
@@ -57,7 +57,6 @@ set_property(TARGET arrow_java_jni_gandiva PROPERTY
OUTPUT_NAME "gandiva_jni")
target_link_libraries(arrow_java_jni_gandiva
arrow_java_jni_gandiva_headers
jni
- protobuf::libprotobuf
Review Comment:
Could you revert this?
##########
.github/workflows/rc.yml:
##########
@@ -259,11 +259,6 @@ jobs:
brew uninstall grpc || : # gRPC depends on RE2
brew uninstall [email protected] || : # gRPC 1.54 may be installed too
brew uninstall re2
- # We want to use bundled Protobuf for static linking. If
- # Homebrew's Protobuf is installed, its library file may be
- # used on test We uninstall Homebrew's Protobuf to ensure using
- # bundled Protobuf.
- brew uninstall protobuf
Review Comment:
Could you revert this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
