anthonylouisbsb commented on a change in pull request #10059:
URL: https://github.com/apache/arrow/pull/10059#discussion_r620635496
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -42,6 +43,12 @@ bool gdv_fn_like_utf8_utf8(int64_t ptr, const char* data,
int data_len,
return (*holder)(std::string(data, data_len));
}
+const char* gdv_fn_regexp_replace_utf8_utf8(int64_t ptr, const char* data, int
data_len,
Review comment:
The stub function needs to accept 2 more additional parameters, the
**length** of the **replace_string** and the length of the output string.
Remember to do the changes in the line the add the function inside the
GlobalMapping functions
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -31,6 +31,7 @@
#include "gandiva/precompiled/types.h"
#include "gandiva/random_generator_holder.h"
#include "gandiva/to_date_holder.h"
+#include "replace_holder.h"
Review comment:
Change to "gandiva/replace_holder.h"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
