[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #24: [DataFusion] Optimize hash join inner workings, null handling fix

[GitBox]

Dandandan commented on a change in pull request #24:
URL: https://github.com/apache/arrow-datafusion/pull/24#discussion_r620640590



##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -708,7 +720,6 @@ macro_rules! equal_rows_elem {
         let right_array = $r.as_any().downcast_ref::<$array_type>().unwrap();
 
         match (left_array.is_null($left), left_array.is_null($right)) {
-            (true, true) => true,

Review comment:
       Yep! To be fair I also added this line myself 😆
   
   I think we also should start testing DataFusion more rigorously wrt null 
handling, but one step at a time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org