zanmato1984 commented on code in PR #48742:
URL: https://github.com/apache/arrow/pull/48742#discussion_r2672757181
##########
cpp/src/arrow/csv/reader.cc:
##########
@@ -769,6 +769,10 @@ class BaseTableReader : public ReaderMixin, public
csv::TableReader {
protected:
// Make column builders from conversion schema
Status MakeColumnBuilders() {
+ // This is making a single copy of ConvertOptions, which is reasonable
even if
Review Comment:
So this is n `shared_ptr` VS. n copies of `ConvertOptions`? (Which makes
sense.)
##########
cpp/src/arrow/csv/reader.cc:
##########
Review Comment:
Ah ok. Thank you.
##########
cpp/src/arrow/csv/column_builder.cc:
##########
Review Comment:
Happen to notice this argument still being const ref instead of a regular
instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
