AdamGS commented on code in PR #597:
URL:
https://github.com/apache/arrow-rs-object-store/pull/597#discussion_r2673611392
##########
src/client/retry.rs:
##########
@@ -844,6 +844,8 @@ mod tests {
// Reset the connection on the first n-1 attempts
for _ in 0..retry.max_retries {
let (stream, _) = listener.accept().await.unwrap();
+ // TcpStream::set_linger is deprecated but this use case is
valid to reset the stream
+ #[allow(deprecated)]
stream.set_linger(Some(Duration::from_secs(0))).unwrap();
Review Comment:
My understanding is that this is more about it being a potential performance
issue than anything else, with the thread being potentially blocked on drop.
This specific options will also be now available in new tokio versions as
`TcpStream::et_linger_zero`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
