kou commented on code in PR #48791: URL: https://github.com/apache/arrow/pull/48791#discussion_r2674897367
########## cpp/CMakeLists.txt: ########## @@ -16,6 +16,8 @@ # under the License. cmake_minimum_required(VERSION 3.25) +# Allow older bundled dependencies to build with CMake 4.0+ +set(CMAKE_POLICY_VERSION_MINIMUM 3.5) Review Comment: Yes. We should not mix separated problems as much as possible. Let's revert this change from this PR, open a separated issue and let's discuss it there. FYI: We already have similar code: https://github.com/apache/arrow/blob/b126c6e7aa85e64ffb4338db8003da0f2b39c069/cpp/cmake_modules/ThirdpartyToolchain.cmake#L1023-L1026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
