kou commented on code in PR #48791:
URL: https://github.com/apache/arrow/pull/48791#discussion_r2677806860
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3984,6 +3984,11 @@ function(build_awssdk)
# We don't need to link aws-lc. It's used only by s2n-tls.
elseif("${AWSSDK_PRODUCT}" STREQUAL "s2n-tls")
list(PREPEND AWSSDK_LINK_LIBRARIES s2n)
+ # Disable -Werror for s2n-tls: it has Clang 18 warnings that it
intentionally allows.
+ # See: https://github.com/aws/s2n-tls/issues/5696
+ if(TARGET s2n)
+ target_compile_options(s2n PRIVATE -Wno-error)
Review Comment:
I don't object the suppression approach but I'm OK with the `-Wno-error`
approach because:
* I think that we don't have enough bandwidth to maintain suppression
options for bundled dependencies
* If I want to suppresses warnings them, I'll fix them in upstream
* Both of `-Wno-error` and `-Wno-XXX`/`-Wno-error=XXX` just ignore warnings.
There are no difference.
* We'll just add more `-Wno-error=XXX` (instead of fixing them) when we
get new warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
