justing-bq commented on code in PR #48577:
URL: https://github.com/apache/arrow/pull/48577#discussion_r2678022645
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/config/configuration.h:
##########
@@ -22,8 +22,10 @@
#include "arrow/flight/sql/odbc/odbc_impl/platform.h"
#include "arrow/flight/sql/odbc/odbc_impl/spi/connection.h"
+#if defined _WIN32 || defined _WIN64
Review Comment:
Just checking _WIN32 now.
##########
cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt:
##########
@@ -52,5 +47,13 @@ add_arrow_test(flight_sql_odbc_test
${SQLite3_LIBRARIES}
arrow_odbc_spi_impl)
+# On Windows, cmake uses suffix `DIRS` for ODBC include headers, and
+# on unix, cmake uses suffix `DIR`.
+if(WIN32)
+ target_include_directories(arrow-flight-sql-odbc-test PUBLIC
${ODBC_INCLUDE_DIRS})
+else()
+ target_include_directories(arrow-flight-sql-odbc-test PUBLIC
${ODBC_INCLUDE_DIR})
+endif()
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
