klion26 commented on code in PR #9049:
URL: https://github.com/apache/arrow-rs/pull/9049#discussion_r2678224344
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -4158,4 +4159,182 @@ mod test {
assert!(inner_values_result.is_null(1));
assert_eq!(inner_values_result.value(2), 333);
}
+
+ #[test]
+ fn test_variant_get_list_like_safe_cast() {
Review Comment:
Do we need to add some cases for that with `VariantPathElement::Field`(We
don't support `VariantPathElement::Index` in the current pr) or some perfectly
shredded case
When trying to use `shred_variant` to generate some perfectly shredded
cases, I found that the member variable `value` is not null for the return
value of `shred_variant`. Is this the expected behavior? According to the
[parquet-vairant-spec](https://github.com/apache/parquet-format/blob/master/VariantShredding.md#arrays)
> If the value is not an array, typed_value must be null. If the value is an
array, value must be null.
<img width="985" height="234" alt="Image"
src="https://github.com/user-attachments/assets/16659ea7-1727-447d-8387-faa861874dcc";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
