jonkeane commented on PR #48634: URL: https://github.com/apache/arrow/pull/48634#issuecomment-3732833918
> I guess they still would most likely get flagged up in our CRAN checks, and I don't see that one listed explicitly; tempted to leave as-is to save the hassle. @jonkeane - given you're submitting it, what do you think? > If I understand correctly, ATTRIB and SET_ ATTRIB are caught only on R-devel. Actually, we see the NOTEs only on R-devel. The backport very much should work. Here is an example that we did for `Rf_findVarInFrame3()`: https://github.com/apache/arrow/blob/0b9f06c78ca549ee3a3aed91b58de740ed90f12e/r/src/arrow_cpp11.h#L390-L400 So if we want to do that now, that would be cleaner and we won't need to come back to it. But I also would be ok to merge this as is with a follow on to do that cleanup if that's more expedient (with the upcoming release + time we all have available to dedicate to this). If we do defer it and come back to it, mind making a follow up ticket if you haven't already? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
