thisisnic commented on code in PR #48601:
URL: https://github.com/apache/arrow/pull/48601#discussion_r2681270229
##########
cpp/src/arrow/config.h:
##########
@@ -64,13 +64,6 @@ struct RuntimeInfo {
/// The SIMD level available on the OS and CPU
std::string detected_simd_level;
-
- /// Whether using the OS-based timezone database
- /// This is set at compile-time.
- bool using_os_timezone_db;
-
- /// The path to the timezone database; by default None.
- std::optional<std::string> timezone_db_path;
Review Comment:
Had a look and my understanding of the situation here is:
- we need to match CRAN builds on our CI so we don't fail CRAN checks
- we use containers from rhub which match the CRAN CI
- we're using one called ubuntu-gcc12 in our CI, which is a bit out of date
and needs updating to actually match CRAN
- everything else uses gcc 13+
So effectively, it'll cause failures on our CI, which is using a container
which is out of date anyway, but I can submit a PR to rhub to bump the gcc
version and just update the version of gcc installed on that container in our
CI in the meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
