EmilyMatt commented on code in PR #8930:
URL: https://github.com/apache/arrow-rs/pull/8930#discussion_r2683966835
##########
arrow-avro/src/reader/async_reader/object_store_reader.rs:
##########
@@ -0,0 +1,52 @@
+use crate::reader::async_reader::{AsyncFileReader, DataFetchFutureBoxed};
+use arrow_schema::ArrowError;
+use std::ops::Range;
+use std::sync::Arc;
+
+/// An implementation of an AsyncFileReader using the
[`object_store::ObjectStore`] API.
+pub struct ObjectStoreFileReader {
+ store: Arc<dyn object_store::ObjectStore>,
+ location: object_store::path::Path,
+}
+
+impl ObjectStoreFileReader {
+ /// Creates a new [`Self`] from a store implementation and file location.
+ pub fn new(
+ store: Arc<dyn object_store::ObjectStore>,
+ location: object_store::path::Path,
+ ) -> Self {
+ Self { store, location }
+ }
+}
Review Comment:
Nice, yeah looks good, I will take another look at the parquet impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
