SmritiAgrawal04 commented on PR #552: URL: https://github.com/apache/arrow-rs-object-store/pull/552#issuecomment-3742964508
> Thanks @SmritiAgrawal04 -- i left some more questions > > BTW I asked codex for a review of this PR like this > > ``` > please review this PR (checked out in this directory): https://github.com/apache/arrow-rs-object-store/pull/552 > > Specifically ensure that the format of the URLs supported matches publically published microsoft urls and provide documentation references > ``` > > And this was the output which I found helpful > > ─────────────────────────────────────────────────────────────────────────────────────────────── > > • Findings > > * High: -api.onelake.fabric.microsoft.com is accepted for both abfs(s) and https, but I can’t find this FQDN in > the public OneLake URL docs. The published endpoints are onelake.dfs.fabric.microsoft.com and workspace-scoped > https://{workspaceId}.z{xy}.dfs.fabric.microsoft.com/... (see https://learn.microsoft.com/en-us/fabric/onelake/ > onelake-access-api). If -api.onelake is internal or not publicly documented, this should be gated or removed. > * Medium: The WS‑PL regex no longer verifies that z{xy} matches the first two hex chars of the workspace id (src/ > azure/builder.rs:692-708). The published WS‑PL format is https:// > {workspaceId}.z{first2}.dfs.fabric.microsoft.com (same doc). Without the check, non‑published FQDNs are > accepted. > * Medium: WS‑PL regex allows .onelake.fabric.microsoft.com (src/azure/builder.rs:692-699). The public docs list > dfs (and blob endpoints for blob access), but I don’t see onelake as a WS‑PL subdomain. Please confirm with a > Microsoft reference or remove to match published formats. > * Low: WS‑PL regex only allows lowercase hex ([0-9a-f]{32}) (src/azure/builder.rs:697). If Microsoft treats > workspace IDs as case‑insensitive GUIDs in URLs, this will reject valid uppercase forms; consider documenting > that only lowercase is supported or make the regex case‑insensitive. > > Doc references > > * OneLake access API URL formats: https://learn.microsoft.com/en-us/fabric/onelake/onelake-access-api > * Private Link / workspace-specific OneLake endpoints (if this PR targets WS‑PL): please confirm the exact doc > section that defines the workspaceId.z{xy}.dfs.fabric.microsoft.com pattern and whether any onelake WS‑PL host > is documented (I could not find it in public docs). > > Questions / assumptions > > * Is *-api.onelake.fabric.microsoft.com a publicly documented endpoint? If yes, can you point to the Microsoft > doc so we can cite it in code/tests? > * Should WS‑PL accept only dfs/blob subdomains, or is .onelake.fabric.microsoft.com explicitly published? Hi @ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
