alamb commented on PR #9121:
URL: https://github.com/apache/arrow-rs/pull/9121#issuecomment-3744047879
I could not reproduce the benchmark results locally
```
Running benches/arrow_reader.rs
(target/release/deps/arrow_reader-0c5ec49ee5cbea6a)
arrow_array_reader/BinaryViewArray/plain encoded, mandatory, no NULLs, short
string
time: [160.36 µs 160.64 µs 161.02 µs]
change: [−0.4158% −0.0942% +0.2111%] (p = 0.56 >
0.05)
No change in performance detected.
Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) high mild
8 (8.00%) high severe
arrow_array_reader/BinaryViewArray/plain encoded, mandatory, no NULLs
time: [147.70 µs 148.37 µs 149.07 µs]
change: [+0.7348% +1.2863% +1.8236%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 25 outliers among 100 measurements (25.00%)
19 (19.00%) low mild
4 (4.00%) high mild
2 (2.00%) high severe
arrow_array_reader/BinaryViewArray/plain encoded, optional, no NULLs
time: [147.02 µs 147.41 µs 147.88 µs]
change: [−1.3623% −0.8303% −0.2939%] (p = 0.00 <
0.05)
Change within noise threshold.
arrow_array_reader/BinaryViewArray/plain encoded, optional, half NULLs
time: [142.34 µs 142.93 µs 143.58 µs]
change: [−1.6259% −0.8845% −0.2890%] (p = 0.01 <
0.05)
Change within noise threshold.
Found 24 outliers among 100 measurements (24.00%)
9 (9.00%) low severe
2 (2.00%) low mild
6 (6.00%) high mild
7 (7.00%) high severe
```
However, note the number of outliers found
I will see if the benchmark needs adjusting (perhaps with more rows, etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
