AntoinePrv commented on PR #47168: URL: https://github.com/apache/arrow/pull/47168#issuecomment-3748469088
Thanks for picking up the work @zanmato1984 > > * Is 18.1.8 OK? It seems that the latest available version is 21.1.8: [pre-commit/mirrors-clang-format/tags](https://github.com/pre-commit/mirrors-clang-format/tags) > > I used v18 to match the version used in the rest of our CI, see [#47168 (comment)](https://github.com/apache/arrow/pull/47168#issuecomment-3733040671) . The biggest blocker for was with pre-commit (recent clang-format hooks did not support earlier versions), apart from that I don't see why not go to the most recent (for me that is better because I constrain the `clangd` LSP I use to the version of `clang-format` used in Arrow so that my editor formatting does not diverge). But yes, most important is that all versions match in Arrow CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
