chakkk309 commented on code in PR #48615: URL: https://github.com/apache/arrow/pull/48615#discussion_r2689891782
########## cpp/src/arrow/util/secure_string.cc: ########## @@ -18,23 +18,13 @@ // __STDC_WANT_LIB_EXT1__ and string.h are required by memset_s: // https://en.cppreference.com/w/c/string/byte/memset #define __STDC_WANT_LIB_EXT1__ 1 +#include <span> #include <string.h> #include <utility> -#if defined(ARROW_USE_OPENSSL) -# include <openssl/crypto.h> -# include <openssl/opensslv.h> -#endif - #include "arrow/util/windows_compatibility.h" -#if defined(_WIN32) -# include <windows.h> -#endif - Review Comment: This was an accidental removal on my part, and I’ll restore the required items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
