raulcd commented on code in PR #48618:
URL: https://github.com/apache/arrow/pull/48618#discussion_r2690106092
##########
ci/scripts/python_wheel_macos_build.sh:
##########
@@ -175,6 +175,11 @@ export CMAKE_PREFIX_PATH=${build_dir}/install
export SETUPTOOLS_SCM_PRETEND_VERSION=${PYARROW_VERSION}
pushd ${source_dir}/python
+# We first populate stub docstrings and then build the wheel
+python setup.py build_ext --inplace
+python -m pip install griffe libcst
+python ../dev/update_stub_docstrings.py pyarrow-stubs
Review Comment:
this is not necessary, right?
##########
ci/scripts/python_wheel_validate_contents.py:
##########
@@ -35,6 +35,11 @@ def validate_wheel(path):
assert not outliers, f"Unexpected contents in wheel: {sorted(outliers)}"
print(f"The wheel: {wheels[0]} seems valid.")
+ candidates = [info for info in f.filelist if
info.filename.endswith('compute.pyi')]
Review Comment:
We should remove this until we have real annotations otherwise it will fail,
`compute.pyi` won't exist, right?
##########
ci/scripts/python_wheel_windows_build.bat:
##########
@@ -135,6 +135,10 @@ pushd C:\arrow\python
@REM Build wheel
%PYTHON_CMD% setup.py bdist_wheel || exit /B 1
+@REM We first populate stub docstrings and then build the wheel
+%PYTHON_CMD% setup.py build_ext --inplace
+%PYTHON_CMD% -m pip install griffe libcst
Review Comment:
Until we have real annotations this isn't necessary, right?
##########
compose.yaml:
##########
@@ -1001,14 +1003,16 @@ services:
ARROW_S3: "OFF"
ARROW_SUBSTRAIT: "OFF"
ARROW_WITH_OPENTELEMETRY: "OFF"
+ PYARROW_TEST_ANNOTATIONS: "ON"
Review Comment:
I think is worth it if instead of using a separate
`ci/scripts/python_test_type_annotations.sh` we use `ci/scripts/python_test.sh`
and we use the `PYARROW_TEST_ANNOTATIONS` variable to manage whether we want
annotations to be tested or not as part of python testing.
If we decide we want to have two separate scripts I think this env var
should be removed.
I lean towards having a single python test script that can allow us to also
test annotations but I can find arguments for both so not an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
