HuaHuaY commented on code in PR #48851:
URL: https://github.com/apache/arrow/pull/48851#discussion_r2689294576
##########
cpp/src/arrow/util/compression_zstd.cc:
##########
@@ -207,8 +216,12 @@ class ZSTDCodec : public Codec {
Result<int64_t> Compress(int64_t input_len, const uint8_t* input,
int64_t output_buffer_len, uint8_t* output_buffer)
override {
- size_t ret = ZSTD_compress(output_buffer,
static_cast<size_t>(output_buffer_len),
- input, static_cast<size_t>(input_len),
compression_level_);
+ if (compression_context_ == nullptr) {
+ compression_context_ = ZSTD_createCCtx();
Review Comment:
The comments in your issue show that the codec methods are not multi-thread
safe. But there are many fail unit tests. I will check whether codec is shared
in multiple threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
