tustvold commented on issue #443:
URL: 
https://github.com/apache/arrow-rs-object-store/issues/443#issuecomment-3751524135

   Trying to catch up on this, it does appear that 
https://github.com/apache/arrow-rs-object-store/pull/399 introduced a breaking 
change to the way we parsed `az://` urls. 
   
   Previously `ObjectStoreScheme::parse`
   
   ```
   az://account/container/path -> (ObjectStoreScheme::MicrosoftAzure, 
container/path)
   ```
   
   Now it returns
   
   ```
   az://account/container/path -> (ObjectStoreScheme::MicrosoftAzure, path)
   ```
   
   This is _technically_ more correct, and is what is documented on 
`ObjectStoreScheme::parse`, however, it appears that the behaviour in 
https://github.com/apache/arrow-rs-object-store/blob/main/src/azure/builder.rs#L666
 reflects a different interpretation of the URLs. I believe this is incorrect, 
as without the account name the URL is incomplete.
   
   To make matters even more confusing, we also have support for azure://, 
abfs://, adl:// that currently all parse in slightly different ways.
   
   My suggestion is to make a breaking change that treats all these schemes in 
the same way:
   
   * `[az|abfs|adl|azure]://<account>/<container>/<path>`  
   * `[az|abfs|adl|azure]://<container>@<account>.<host>/<path>`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to