waynexia commented on PR #9092: URL: https://github.com/apache/arrow-rs/pull/9092#issuecomment-3754146322
Another one `impl Array for T` example here https://github.com/GreptimeTeam/greptimedb/blob/e0285209cb62b398ce89a033a1101991d4a28b27/src/promql/src/range_array.rs#L228 . It wraps a dictionary array into a matrix-like structure. Despite whether this impl is reasonable, or has a better alternative, `Array` is one of the biggest abstractions exposed from `arrow`. Many downstream lib like datafusion only accepts `Array` (record batch), this sealing also removes a large hack point to play around with data representation and computation. And adding a new implementation of `Array` to this arrow library is a hard long journey (like variant array) or not even acceptable (like range array for a specific usage). IMHO, this breaking is shipped too fast, and on a minor version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
