alamb commented on code in PR #9182:
URL: https://github.com/apache/arrow-rs/pull/9182#discussion_r2694345723
##########
arrow-select/src/take.rs:
##########
@@ -786,6 +786,11 @@ fn take_run<T: RunEndIndexType, I: ArrowPrimitiveType>(
run_array: &RunArray<T>,
logical_indices: &PrimitiveArray<I>,
) -> Result<RunArray<T>, ArrowError> {
+ if logical_indices.is_empty() {
Review Comment:
I agree with @Jefffrey it would be great to move this check up into `take`
However, given this PR is better than what is on main, I think we could also
merge it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
