alamb commented on code in PR #9190:
URL: https://github.com/apache/arrow-rs/pull/9190#discussion_r2694390283
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -1597,18 +1601,21 @@ impl<T: ArrowTimestampType> PrimitiveArray<T> {
/// Constructs a `PrimitiveArray` from an array data reference.
impl<T: ArrowPrimitiveType> From<ArrayData> for PrimitiveArray<T> {
fn from(data: ArrayData) -> Self {
- Self::assert_compatible(data.data_type());
+ let (data_type, len, nulls, offset, mut buffers, _child_data) =
data.into_parts();
+
+ Self::assert_compatible(&data_type);
assert_eq!(
- data.buffers().len(),
+ buffers.len(),
1,
"PrimitiveArray data should contain a single buffer only (values
buffer)"
);
+ let buffer = buffers.pop().expect("checked above");
- let values = ScalarBuffer::new(data.buffers()[0].clone(),
data.offset(), data.len());
+ let values = ScalarBuffer::new(buffer, offset, len);
Self {
- data_type: data.data_type().clone(),
+ data_type,
values,
- nulls: data.nulls().cloned(),
Review Comment:
This saves a clone /call to DataType::drop as well as a Clone of `Buffer`
(which is fairly inexpensive).
I don't think it will make any different in performance, but the code is
cleaner and now consistent with other array types so I think this change is
worth making
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
