alamb commented on code in PR #9187:
URL: https://github.com/apache/arrow-rs/pull/9187#discussion_r2694493438
##########
arrow-array/src/array/fixed_size_list_array.rs:
##########
@@ -439,14 +441,13 @@ impl From<ArrayData> for FixedSizeListArray {
};
let size = value_length as usize;
- let values =
- make_array(data.child_data()[0].slice(data.offset() * size,
data.len() * size));
+ let values = make_array(child_data[0].slice(offset * size, len *
size));
Review Comment:
this still bothers me -- `slice()` allocates a bunch of new children
ArrayDatas when I think it could mutate them in place. I'll see what I can do
as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
