Jefffrey commented on code in PR #9198:
URL: https://github.com/apache/arrow-rs/pull/9198#discussion_r2697241908
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -2746,6 +2765,21 @@ mod tests {
use half::f16;
use std::sync::Arc;
+ #[test]
+ fn test_decimal128_to_float16_cast() {
Review Comment:
We need more testing:
- Cover all decimal types
- Actually check the output of the cast (right now this only checks casting
succeeds and null value
I would suggest looking at the other test cases in this file for how to
structure test casts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
