wgtmac commented on code in PR #48865:
URL: https://github.com/apache/arrow/pull/48865#discussion_r2697433498
##########
cpp/src/parquet/properties_test.cc:
##########
@@ -81,9 +81,13 @@ TEST(TestWriterProperties, AdvancedHandling) {
}
TEST(TestWriterProperties, SetCodecOptions) {
+ constexpr int ZSTD_c_windowLog = 101;
Review Comment:
Should we use `kZstdCWindowLog` to be consistent with this code base?
##########
cpp/src/arrow/util/compression.h:
##########
@@ -142,6 +144,15 @@ class ARROW_EXPORT BrotliCodecOptions : public
CodecOptions {
std::optional<int> window_bits;
};
+// ----------------------------------------------------------------------
+// Zstd codec options implementation
+
+class ARROW_EXPORT ZstdCodecOptions : public CodecOptions {
+ public:
+ std::vector<std::pair<int, int>> compression_context_params;
Review Comment:
Add a comment to inform that valid keys can be found at
https://facebook.github.io/zstd/zstd_manual.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
