alamb commented on code in PR #9194:
URL: https://github.com/apache/arrow-rs/pull/9194#discussion_r2694399193
##########
arrow-array/src/array/list_array.rs:
##########
@@ -479,23 +479,26 @@ impl<OffsetSize: OffsetSizeTrait>
From<FixedSizeListArray> for GenericListArray<
impl<OffsetSize: OffsetSizeTrait> GenericListArray<OffsetSize> {
fn try_new_from_array_data(data: ArrayData) -> Result<Self, ArrowError> {
- if data.buffers().len() != 1 {
+ let (data_type, len, nulls, offset, mut buffers, mut child_data) =
data.into_parts();
+
+ if buffers.len() != 1 {
return Err(ArrowError::InvalidArgumentError(format!(
"ListArray data should contain a single buffer only (value
offsets), had {}",
- data.buffers().len()
+ buffers.len()
)));
}
+ let buffer = buffers.pop().expect("checked above");
- if data.child_data().len() != 1 {
+ if child_data.len() != 1 {
return Err(ArrowError::InvalidArgumentError(format!(
"ListArray should contain a single child array (values array),
had {}",
- data.child_data().len()
+ child_data.len()
)));
}
- let values = data.child_data()[0].clone();
Review Comment:
here we save a clone of ArrayData (and thus a Vec allocation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
