birschick-bq commented on code in PR #3896:
URL: https://github.com/apache/arrow-adbc/pull/3896#discussion_r2700391991


##########
csharp/src/Apache.Arrow.Adbc/Tracing/TracingStatement.cs:
##########
@@ -22,6 +22,7 @@ namespace Apache.Arrow.Adbc.Tracing
     public abstract class TracingStatement : AdbcStatement, ITracingStatement
     {
         private readonly ActivityTrace _trace;
+        private string? _statementTraceParent;

Review Comment:
   I'm not convinced we need a separate trace parent for statements.
   
   Because the statement will use the connection to make calls, if the trace 
parent is not passed to the connection, the connection tracing won't include 
the trace parent value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to