alamb commented on PR #8951: URL: https://github.com/apache/arrow-rs/pull/8951#issuecomment-3763734164
The reason the existing test coverage for filter batch doesn't cover the new code is that it uses a multi-column record batch Another thing I noticed around while trying to test is that the filter predicate passed to `copy_rows_by_filter` is for a sliced filter array, but the underlying InProgressArrays seem to treat it as though it started at the start of the array I think that may be a bug, but I am looking more carefully now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
