alamb commented on code in PR #8700:
URL: https://github.com/apache/arrow-rs/pull/8700#discussion_r2701256793
##########
arrow-cast/src/parse.rs:
##########
@@ -861,19 +850,19 @@ pub fn parse_decimal<T: DecimalType>(
let mut digits: u8 = 0;
let base = T::Native::usize_as(10);
+ if matches!(s, "" | "-" | "+" | "." | "1e" | "1e+" | "1e-") {
Review Comment:
this feels like an oddly specific list of error conditions to check -- It
seems like it should be checking that s has only digits and is not empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
