alamb opened a new pull request, #9218: URL: https://github.com/apache/arrow-rs/pull/9218
# Which issue does this PR close? - part of https://github.com/apache/arrow-rs/issues/9136 from @Dandandan # Rationale for this change This PR from @Dandandan adds a bunch of (very cool) special casess for filtering in the coalescer: - https://github.com/apache/arrow-rs/pull/8951 However, these new special cases are not covered by existing tests, so let's increase the coverage # What changes are included in this PR? Add coverage for the following cases // 1. non-null fast path // 2. Empty batches // 3. One column (from the batch) I also added names to the tests as now each test is run in several different permutations so I wanted to assist debugging # Are these changes tested? All the tests pass (which is verified by CI) I verified coverge of the special cases with ``` cargo llvm-cov test --html -p arrow-select ``` # Are there any user-facing changes? No, this is test change only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
