rluvaton commented on code in PR #9176:
URL: https://github.com/apache/arrow-rs/pull/9176#discussion_r2704000773
##########
arrow-row/src/lib.rs:
##########
@@ -3132,6 +3219,143 @@ mod tests {
test_nested_list::<i64>();
}
+ fn test_single_list_view<O: OffsetSizeTrait>() {
Review Comment:
Please add more tests that take advantage of the fact that this is a view,
namely
- both list point to the same value.
- unordered offsets (one item is from offset x and some item after that is
from offset y and y is before x)
- list 1 items cover list 2 items and a little more (e.g. list 1 offset is
10 and size 5 and list 2 offset is 12 and size 2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
