adamreeve commented on code in PR #48859:
URL: https://github.com/apache/arrow/pull/48859#discussion_r2706047947
##########
cpp/src/parquet/metadata.h:
##########
@@ -331,9 +332,12 @@ class PARQUET_EXPORT FileMetaData {
EncryptionAlgorithm encryption_algorithm() const;
const std::string& footer_signing_key_metadata() const;
- /// \brief Verify signature of FileMetaData when file is encrypted but footer
- /// is not encrypted (plaintext footer).
+ PARQUET_DEPRECATED("Deprecated in 24.0.0. Use the two-argument overload
instead.")
bool VerifySignature(const void* signature);
Review Comment:
Yes I can't see why this would need to be part of the public API. In which
case, the new method should probably be private or internal too.
If we remove it and make the new method internal then this could block
someone from upgrading if they had a legitimate use case for this. Maybe we
should deprecate it and suggest users make an issue if they need this
functionality? Also OK by me if you just want to remove it though, it seems
unlikely this would be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
