rok commented on code in PR #48601:
URL: https://github.com/apache/arrow/pull/48601#discussion_r2710493694
##########
cpp/src/arrow/config.h:
##########
@@ -86,12 +87,20 @@ const BuildInfo& GetBuildInfo();
ARROW_EXPORT
RuntimeInfo GetRuntimeInfo();
-struct GlobalOptions {
- /// Path to text timezone database. This is only configurable on Windows,
- /// which does not have a compatible OS timezone database.
+/// \deprecated Deprecated in 24.0.0. This struct is only needed for
+/// Windows builds with Clang/libc++ and will be removed once libc++
+/// supports std::chrono timezones.
+struct ARROW_DEPRECATED("Deprecated in 24.0.0. Only needed for Clang/libc++ on
Windows.")
+ GlobalOptions {
+ /// Path to text timezone database. This is only configurable on Windows
+ /// builds using Clang/libc++ which require the vendored date library.
std::optional<std::string> timezone_db_path;
Review Comment:
Changed to only deprecate the member.
##########
cpp/src/arrow/config.h:
##########
@@ -86,12 +87,20 @@ const BuildInfo& GetBuildInfo();
ARROW_EXPORT
RuntimeInfo GetRuntimeInfo();
-struct GlobalOptions {
- /// Path to text timezone database. This is only configurable on Windows,
- /// which does not have a compatible OS timezone database.
+/// \deprecated Deprecated in 24.0.0. This struct is only needed for
+/// Windows builds with Clang/libc++ and will be removed once libc++
+/// supports std::chrono timezones.
+struct ARROW_DEPRECATED("Deprecated in 24.0.0. Only needed for Clang/libc++ on
Windows.")
+ GlobalOptions {
+ /// Path to text timezone database. This is only configurable on Windows
+ /// builds using Clang/libc++ which require the vendored date library.
std::optional<std::string> timezone_db_path;
};
+/// \deprecated Deprecated in 24.0.0. This function is only needed for
+/// Windows builds with Clang/libc++ and will be removed once libc++
+/// supports std::chrono timezones.
+ARROW_DEPRECATED("Deprecated in 24.0.0. Only needed for Clang/libc++ on
Windows.")
Review Comment:
Changed to only deprecate the member.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
