daniel-adam-tfs commented on code in PR #596:
URL: https://github.com/apache/arrow-go/pull/596#discussion_r2713845438
##########
parquet/file/file_reader_test.go:
##########
@@ -207,7 +207,7 @@ func (p *PageSerdeSuite) TestDataPageV2() {
p.dataPageHdrV2.Statistics = getDummyStats(statsSize, true)
p.dataPageHdrV2.NumValues = nrows
- p.WriteDataPageHeaderV2(1024, 20, 10)
+ p.WriteDataPageHeaderV2(1024, 0, 0)
Review Comment:
yep, there are no raw bytes so the ReadFull returns EOF error, which was
ignored previously, but for which I now check for. I don't see a reason why the
error should be ignored, but maybe I'm missing something...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
