kou commented on code in PR #48934:
URL: https://github.com/apache/arrow/pull/48934#discussion_r2715059413
##########
.github/workflows/cpp_extra.yml:
##########
@@ -451,18 +453,39 @@ jobs:
wix --version
cd build/cpp
cpack
+ cd ../..
+ Move-Item -Path "build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi"
-Destination "."
- name: Upload the artifacts to the job
uses: actions/upload-artifact@v6
with:
name: flight-sql-odbc-msi-installer
- path: build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi
+ path: Apache Arrow Flight SQL ODBC-*-win64.msi
if-no-files-found: error
+ # Upload ODBC as GitHub release if release candidate tag is used
+ - name: Wait for creating GitHub Release
+ shell: bash
+ if: github.ref_type == 'tag'
+ env:
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ dev/release/utils-watch-gh-workflow.sh \
+ ${GITHUB_REF_NAME} \
+ release_candidate.yml
+ - name: Upload the artifacts to GitHub Release
+ shell: bash
+ if: github.ref_type == 'tag'
+ env:
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ gh release upload ${GITHUB_REF_NAME} \
+ --clobber \
+ "Apache Arrow Flight SQL ODBC-*-win64.msi"
Review Comment:
`"Apache Arrow Flight SQL ODBC-*-win64.msi"` will not be expanded by bash...:
```suggestion
Apache\ Arrow\ Flight\ SQL\ ODBC-*-win64.msi
```
##########
.github/workflows/cpp_extra.yml:
##########
@@ -451,18 +453,39 @@ jobs:
wix --version
cd build/cpp
cpack
+ cd ../..
+ Move-Item -Path "build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi"
-Destination "."
- name: Upload the artifacts to the job
uses: actions/upload-artifact@v6
with:
name: flight-sql-odbc-msi-installer
- path: build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi
+ path: Apache Arrow Flight SQL ODBC-*-win64.msi
if-no-files-found: error
+ # Upload ODBC as GitHub release if release candidate tag is used
+ - name: Wait for creating GitHub Release
+ shell: bash
+ if: github.ref_type == 'tag'
+ env:
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ dev/release/utils-watch-gh-workflow.sh \
+ ${GITHUB_REF_NAME} \
+ release_candidate.yml
+ - name: Upload the artifacts to GitHub Release
+ shell: bash
+ if: github.ref_type == 'tag'
+ env:
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ gh release upload ${GITHUB_REF_NAME} \
+ --clobber \
+ "Apache Arrow Flight SQL ODBC-*-win64.msi"
Review Comment:
We don't need to add release notes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
