h-vetinari commented on issue #48874: URL: https://github.com/apache/arrow/issues/48874#issuecomment-3788531203
Quick update: I backported #48601 to v22 in https://github.com/conda-forge/arrow-cpp-feedstock/pull/1913; that gets us quite a bit further, but there are still some remaining failures: ``` 98% tests passed, 2 tests failed out of 102 [...] The following tests FAILED: 100 - gandiva-internals-test (Failed) gandiva-tests unittest 102 - gandiva-projector-test (Failed) gandiva-tests unittest ``` <details> ### `gandiva-internals-test` ``` [ RUN ] TestGdvFnStubs.TestToUtcTimezone %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1081): error: Expected equality of these values: 1330423200000 ts2 Which is: 0 %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1087): error: Expected equality of these values: ts2 Which is: 0 -1800000 %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1094): error: Expected equality of these values: ts2 Which is: 0 1520758800000 %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1100): error: Expected equality of these values: ts2 Which is: 0 1520841600000 %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1104): error: Value of: context.get_error() Expected: is equal to "America/LA is an invalid time zone name." Actual: "Asia/Kolkata is an invalid time zone name." [ FAILED ] TestGdvFnStubs.TestToUtcTimezone (5 ms) [ RUN ] TestGdvFnStubs.TestFromUtcTimezone %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1118): error: Expected equality of these values: ts2 Which is: 0 55800000 %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1124): error: Expected equality of these values: ts2 Which is: 0 18000000 %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1130): error: Expected equality of these values: ts2 Which is: 0 1520730000000 %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1136): error: Expected equality of these values: ts2 Which is: 0 1520816400000 %SRC_DIR%\cpp\src\gandiva\gdv_function_stubs_test.cc(1140): error: Value of: context.get_error() Expected: is equal to "India is an invalid time zone name." Actual: "Asia/Kolkata is an invalid time zone name." [ FAILED ] TestGdvFnStubs.TestFromUtcTimezone (0 ms) [...] [----------] Global test environment tear-down [==========] 143 tests from 26 test suites ran. (647 ms total) [ PASSED ] 141 tests. [ FAILED ] 2 tests, listed below: [ FAILED ] TestGdvFnStubs.TestToUtcTimezone [ FAILED ] TestGdvFnStubs.TestFromUtcTimezone 2 FAILED TESTS ``` ### `gandiva-projector-test` ``` [ RUN ] DateTimeTestProjector.TestToUtcTimestamp %SRC_DIR%\cpp\src\gandiva\tests\date_time_test.cc(771): error: Value of: status.ok() Actual: false Expected: true unknown file: error: C++ exception with description "invalid vector subscript" thrown in the test body. [ FAILED ] DateTimeTestProjector.TestToUtcTimestamp (49 ms) [ RUN ] DateTimeTestProjector.TestFromUtcTimestamp %SRC_DIR%\cpp\src\gandiva\tests\date_time_test.cc(826): error: Value of: status.ok() Actual: false Expected: true unknown file: error: C++ exception with description "invalid vector subscript" thrown in the test body. [ FAILED ] DateTimeTestProjector.TestFromUtcTimestamp (46 ms) [----------] 12 tests from DateTimeTestProjector (1131 ms total) [...] [----------] Global test environment tear-down [==========] 211 tests from 16 test suites ran. (19339 ms total) [ PASSED ] 209 tests. [ FAILED ] 2 tests, listed below: [ FAILED ] DateTimeTestProjector.TestToUtcTimestamp [ FAILED ] DateTimeTestProjector.TestFromUtcTimestamp 2 FAILED TESTS YOU HAVE 2 DISABLED TESTS ``` </details> Part of that could of course be due to the backport to v22 (which cherry-picked cleanly though, aside from some CI config), but I won't get around fixing this also on v22 one way or another. I was planning to fix CI on v22 first and then try v23. If helpful, I can also try out v23 (with the backport of #48601) as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
