wgtmac commented on code in PR #48692:
URL: https://github.com/apache/arrow/pull/48692#discussion_r2719812842
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -2463,5 +2464,84 @@ TYPED_TEST(TestBloomFilterWriter, Basic) {
}
}
+class TestArrowWriteSerialize : public ::testing::Test {
Review Comment:
I'm not sure if this is the right place to add this test. It seems that
`column_writer_test.cc` does not deal with writing Arrow arrays. Is it better
to move it to the `arrow_reader_writer_test.cc` by manually creating an Arrow
array with all null values and null value buffer? In that approach, we don't
need to deal with boilerplate like `ColumnChunkMetaDataBuilder`, `PageWriter`
and `ColumnWriter` below. BTW, we can also use `TEST` instead of `TEST_F` with
class definition because we only have one case here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
