jecsand838 commented on code in PR #8759:
URL: https://github.com/apache/arrow-rs/pull/8759#discussion_r2719850362
##########
arrow-avro/src/reader/mod.rs:
##########
@@ -835,7 +835,7 @@ impl Decoder {
// We must flush the active decoder before switching to the pending
one.
let batch = self.flush_and_reset();
self.apply_pending_schema();
- batch
+ batch.map_err(ArrowError::from)
Review Comment:
I'm actually curious, why are we not following the pattern used by `parquet`
and just return the `pub AvroError`? I thought that was the big reason for
doing this PR and waiting for a major release?
I re-read the PR description and just caught this part, not sure I fully
agree. I'm thinking we should either return `AvroError` or
`ArrowError::AvroError` as part of the public API to align with the other
crates and help downstream callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
