rok commented on code in PR #48618:
URL: https://github.com/apache/arrow/pull/48618#discussion_r2720801461
##########
.github/workflows/python.yml:
##########
@@ -239,6 +239,11 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/python_test.sh $(pwd) $(pwd)/build
+ - name: Test annotations
+ shell: bash
+ env:
+ PYARROW_TEST_ANNOTATIONS: "ON"
+ run: ci/scripts/python_test_type_annotations.sh $(pwd)/python
Review Comment:
That's a nice idea! So instead of a new workflow step you are proposing we
move these checks into pre-commit script, correct? I'll change to pre-commit
approach.
One thing I wonder about - are there users that run all these checks locally
and would not like the new extra jobs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
