kou commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r2720852823
##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -4334,8 +4402,8 @@ garrow_rank_options_set_property(GObject *object,
switch (prop_id) {
case PROP_RANK_OPTIONS_NULL_PLACEMENT:
- options->null_placement =
- static_cast<arrow::compute::NullPlacement>(g_value_get_enum(value));
+ options->null_placement = garrow_optional_null_placement_to_raw(
+ static_cast<GArrowOptionalNullPlacement>(g_value_get_enum(value)));
Review Comment:
Ah, we have multiple places that use these helper functions. I missed them.
Sorry.
Could you export these helper functions from `compute.hpp` instead of
defining them in an anonymous namespace? And could you simplify these helper
functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
