nateprewitt commented on issue #41990: URL: https://github.com/apache/arrow/issues/41990#issuecomment-3791352844
I've put up a PR that attempts to address this in https://github.com/apache/arrow/pull/48971. From local testing, I think we need to move the destructor onto the actual implementation to satisfy MSVC. I'm basing this off this information from [cppreference](https://en.cppreference.com/w/cpp/memory/unique_ptr.html): > unique_ptr may be constructed for an [incomplete type](https://en.cppreference.com/w/cpp/language/type-id.html#Incomplete_type) T, such as to facilitate the use as a handle in the [pImpl idiom](https://en.cppreference.com/w/cpp/language/pimpl.html). If the default deleter is used, T must be complete at the point in code where the deleter is invoked, which happens in the destructor, move assignment operator, and reset member function of unique_ptr. It's possible I'm missing some nuance, but this patch does appear to address the underlying compilation problem. I've provided more details in the PR but I'm happy to discuss anything I'm missing. Hopefully this moves the needle forward for getting this enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
