akravchukdremio commented on code in PR #48867:
URL: https://github.com/apache/arrow/pull/48867#discussion_r2729785963
##########
cpp/src/gandiva/precompiled/time_test.cc:
##########
@@ -122,15 +122,26 @@ TEST(TestTime, TestCastTimestamp) {
"Not a valid time for timestamp value 2000-01-01 00:00:100");
context.Reset();
- EXPECT_EQ(castTIMESTAMP_utf8(context_ptr, "2000-01-01 00:00:00.0001", 24),
0);
- EXPECT_EQ(context.get_error(),
- "Invalid millis for timestamp value 2000-01-01 00:00:00.0001");
- context.Reset();
-
- EXPECT_EQ(castTIMESTAMP_utf8(context_ptr, "2000-01-01 00:00:00.1000", 24),
0);
- EXPECT_EQ(context.get_error(),
- "Invalid millis for timestamp value 2000-01-01 00:00:00.1000");
- context.Reset();
+ // Test truncation of subseconds to 3 digits (milliseconds)
Review Comment:
We already have such test cases, see here:
https://github.com/akravchukdremio/arrow/blob/GH-48866/cpp/src/gandiva/precompiled/time_test.cc#L100-L104
and
https://github.com/akravchukdremio/arrow/blob/GH-48866/cpp/src/gandiva/precompiled/time_test.cc#L154-L158.
Seems like enough, but if you think we need more - I can add them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
