klion26 opened a new pull request, #9276: URL: https://github.com/apache/arrow-rs/pull/9276
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes #9050. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? Add `[fieldName]` support in `VariantPath` parser, will throw an error if the parser fails. Also support escaping `\` inside brackets. If we force the use bracket when the field contains special characters, maybe we can also close #8954 Sample behaviors(read more on the code doc) - `[foo]` -> filed `foo` - `[2]` -> index 2 - `[a.b]` -> field `a.b` - `[a\]b]` -> field `a]b` - `[a\xb]` -> field `axb` # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Added tests # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> Yes, there are some user-facing changes, but `parquet-variant` is still experient for now, so maybe we don't need to wait for a major version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
