h-vetinari commented on code in PR #48971: URL: https://github.com/apache/arrow/pull/48971#discussion_r2731173830
########## cpp/src/arrow/filesystem/azurefs.cc: ########## @@ -970,7 +970,7 @@ Status StageBlock(Blobs::BlockBlobClient* block_blob_client, const std::string& /// Writes will be buffered up to this size (in bytes) before actually uploading them. static constexpr int64_t kBlockUploadSizeBytes = 10 * 1024 * 1024; /// The maximum size of a block in Azure Blob (as per docs). -static constexpr int64_t kMaxBlockSizeBytes = 4UL * 1024 * 1024 * 1024; +static constexpr int64_t kMaxBlockSizeBytes = 4LL * 1024 * 1024 * 1024; Review Comment: normally I wouldn't consider `long long` "good for portability", but since the result here is implicitly cast to `int64_t`, that should be fine 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
