AdamGS commented on code in PR #627:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/627#discussion_r2732755740


##########
.github/workflows/ci.yml:
##########
@@ -139,9 +139,11 @@ jobs:
       - name: Configure Azurite (Azure emulation)
         # the magical connection string is from
         # 
https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azurite?tabs=visual-studio#http-connection-strings
+        # We specify an azure-cli version because 2.82 was released before 
azurite supported service version 2026-02-06
+        # see https://github.com/Azure/Azurite/issues/2623
         run: |
           echo "AZURITE_CONTAINER=$(docker run -d -p 10000:10000 -p 
10001:10001 -p 10002:10002 mcr.microsoft.com/azure-storage/azurite)" >> 
$GITHUB_ENV
-          az storage container create -n test-bucket --connection-string 
'DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://localhost:10000/devstoreaccount1;QueueEndpoint=http://localhost:10001/devstoreaccount1;'
+          pipx run --spec azure-cli==2.81.0 az storage container create -n 
test-bucket --connection-string 
'DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://localhost:10000/devstoreaccount1;QueueEndpoint=http://localhost:10001/devstoreaccount1;'

Review Comment:
   As far as I can tell, this is only until azurite adds support for this 
header value.
   Using a pinned azurite version here is probably fine until someone runs into 
some concrete issue with it or wants to use some newer API. 
   Azurite is great and probably as good as it gets, but there are definitely 
some differences between it and upstream Azure (#334 is another example).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to