alinaliBQ commented on code in PR #49005:
URL: https://github.com/apache/arrow/pull/49005#discussion_r2733518290
##########
.github/workflows/cpp_extra.yml:
##########
@@ -434,10 +434,17 @@ jobs:
shell: cmd
run: |
call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{
github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll
- # GH-48270 TODO: Resolve segementation fault during Arrow library unload
- # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI
+ # GH-48270 TODO: Resolve segementation fault during Arrow library
unload, segementation fault is caught with `ci/scripts/cpp_test.sh`
+ # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI and run
tests with `ci/scripts/cpp_test.sh` instead
# GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are
resolved.
-
+ - name: Run ODBC Unit Tests
+ shell: cmd
+ run: |
+ build\cpp\%ARROW_BUILD_TYPE%\arrow-odbc-spi-impl-test.exe
+ - name: Run ODBC Driver Tests
+ shell: cmd
+ run: |
+ build\cpp\%ARROW_BUILD_TYPE%\arrow-flight-sql-odbc-test.exe
Review Comment:
@lidavidm @kou Please have a look at this small PR. I don't see other `.exe`
tests being run without a script in the Arrow repo, so I am not sure this
approach is accepted. If it is a no-go, I can close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
