kou commented on code in PR #48577:
URL: https://github.com/apache/arrow/pull/48577#discussion_r2734473449
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,9 +336,76 @@ jobs:
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
- odbc:
+ odbc-macos:
needs: check-labels
- name: ODBC
+ name: ODBC ${{ matrix.architecture }} macOS ${{ matrix.macos-version }}
+ runs-on: macos-${{ matrix.macos-version }}
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ timeout-minutes: 75
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - architecture: AMD64
+ macos-version: "15-intel"
+ - architecture: ARM64
+ macos-version: "14"
+ env:
+ ARROW_BUILD_TESTS: ON
+ ARROW_FLIGHT_SQL_ODBC: ON
+ ARROW_HOME: /tmp/local
+ steps:
+ - name: Checkout Arrow
+ uses: actions/[email protected]
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Install Dependencies
+ run: |
+ brew bundle --file=cpp/Brewfile
+ - name: Setup ccache
+ run: |
+ ci/scripts/ccache_setup.sh
+ - name: ccache info
+ id: ccache-info
+ run: |
+ echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT
+ - name: Cache ccache
+ uses: actions/cache@v4
Review Comment:
```suggestion
uses: actions/[email protected]
```
##########
cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h:
##########
@@ -237,6 +237,9 @@ static constexpr std::string_view kErrorStateHY114 =
"HY114";
static constexpr std::string_view kErrorStateHY118 = "HY118";
static constexpr std::string_view kErrorStateHYC00 = "HYC00";
static constexpr std::string_view kErrorStateS1004 = "S1004";
+static constexpr std::string_view kErrorStateS1002 = "S1002";
+static constexpr std::string_view kErrorStateS1010 = "S1010";
+static constexpr std::string_view kErrorStateS1090 = "S1090";
Review Comment:
Could you sort them?
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,9 +336,76 @@ jobs:
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
- odbc:
+ odbc-macos:
needs: check-labels
- name: ODBC
+ name: ODBC ${{ matrix.architecture }} macOS ${{ matrix.macos-version }}
+ runs-on: macos-${{ matrix.macos-version }}
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ timeout-minutes: 75
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - architecture: AMD64
+ macos-version: "15-intel"
+ - architecture: ARM64
+ macos-version: "14"
+ env:
+ ARROW_BUILD_TESTS: ON
+ ARROW_FLIGHT_SQL_ODBC: ON
+ ARROW_HOME: /tmp/local
+ steps:
+ - name: Checkout Arrow
+ uses: actions/[email protected]
Review Comment:
```suggestion
uses: actions/[email protected]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
